some small improvements to get everything ready for the sprint #5461
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5461 +/- ##
===========================================
+ Coverage 37.86% 80.23% +42.36%
===========================================
Files 82 82
Lines 14215 13941 -274
===========================================
+ Hits 5382 11185 +5803
+ Misses 8833 2756 -6077
|
|
|
||
| Tags can be anything, but we ask you to try to use [existing tags](https://github.com/pymc-devs/pymc/wiki/Categories-and-Tags-for-PyMC-Examples) | ||
| to avoid the tag list from getting too long. | ||
|
|
||
| Each notebook should have a single category indicating the level of the notebook. | ||
| Choose a category from [existing categories](https://github.com/pymc-devs/pymc/wiki/Categories-and-Tags-for-PyMC-Examples#categories). | ||
| Each notebook should have a one or two categories indicating: |
There was a problem hiding this comment.
I think we should make it two so its not ambiguous , also so its very clear what category a document is in
There was a problem hiding this comment.
The problem is that most notebooks are a mix of different types, so forcing the two categories already is a huge effort. My idea was to use that for new notebooks, for notebooks that already match a type and for notebooks we want to split/combine/restructure
There was a problem hiding this comment.
My suggestion is force two moving forward and we can fix the older ones over time. This way at least at some point in the future all notebooks will have both labels
There was a problem hiding this comment.
sounds good, I have updated the proposal template in pymc-devs/pymc-examples#281. I'd still keep it like this here for now because >95% of the changes that we have to do (and 99.9% of the changes done by newcomers) are updating existent notebooks, not writing new ones
OriolAbril
force-pushed
the
pre_sprint_checks
branch
from
a562321 to
d288f0d
Compare
what are the (breaking) changes that this PR makes?None