Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Mixture distribution for V4 #5438

Merged
merged 13 commits into from
Mar 9, 2022
Merged

Refactor Mixture distribution for V4 #5438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2cddc79
Set `expand=True` when calling `change_size` in `SymbolicDistribution`
ricardoV94 Mar 1, 2022
6de9b20
Move NormalMixture tests to their own class
ricardoV94 Feb 4, 2022
0291fcb
Move mixture random tests from test_distributions_random to test_mixture
ricardoV94 Feb 4, 2022
88b1240
Use specific imports in test_mixture
ricardoV94 Feb 4, 2022
0db5414
Reenable Mixture tests in pytest workflow
ricardoV94 Feb 4, 2022
6a1d739
Refactor Mixture distribution
ricardoV94 Feb 1, 2022
3531ab7
Add warning when using iterable with single Mixture component
ricardoV94 Mar 2, 2022
0d99f53
Update Mixture docstrings
ricardoV94 Mar 2, 2022
524025b
Refactor NormalMixture
ricardoV94 Mar 7, 2022
7406beb
Refactor TestMixtureVsLatent
ricardoV94 Feb 28, 2022
34f4679
Remove MixtureSameFamily
ricardoV94 Mar 1, 2022
04baabd
Add Mixture moments
larryshamalama Feb 1, 2022
0e442d1
Update release notes
ricardoV94 Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ jobs:
pymc/tests/test_transforms.py
pymc/tests/test_smc.py
pymc/tests/test_bart.py
pymc/tests/test_mixture.py

- |
pymc/tests/test_parallel_sampling.py
Expand Down
3 changes: 2 additions & 1 deletion RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Instead update the vNext section until 4.0.0 is out.
### Not-yet working features
We plan to get these working again, but at this point their inner workings have not been refactored.
- Timeseries distributions (see [#4642](https://github.com/pymc-devs/pymc/issues/4642))
- Mixture distributions (see [#4781](https://github.com/pymc-devs/pymc/issues/4781))
- Nested Mixture distributions (see [#5533](https://github.com/pymc-devs/pymc/issues/5533))
- Elliptical slice sampling (see [#5137](https://github.com/pymc-devs/pymc/issues/5137))
- `BaseStochasticGradient` (see [#5138](https://github.com/pymc-devs/pymc/issues/5138))
- `pm.sample_posterior_predictive_w` (see [#4807](https://github.com/pymc-devs/pymc/issues/4807))
Expand Down Expand Up @@ -72,6 +72,7 @@ All of the above apply to:
- In the gp.utils file, the `kmeans_inducing_points` function now passes through `kmeans_kwargs` to scipy's k-means function.
- The function `replace_with_values` function has been added to `gp.utils`.
- `MarginalSparse` has been renamed `MarginalApprox`.
- Removed `MixtureSameFamily`. `Mixture` is now capable of handling batched multivariate components (see [#5438](https://github.com/pymc-devs/pymc/pull/5438)).
- ...

### Expected breaks
Expand Down
1 change: 0 additions & 1 deletion docs/source/api/distributions/mixture.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ Mixture

Mixture
NormalMixture
MixtureSameFamily
3 changes: 1 addition & 2 deletions pymc/distributions/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
NoDistribution,
SymbolicDistribution,
)
from pymc.distributions.mixture import Mixture, MixtureSameFamily, NormalMixture
from pymc.distributions.mixture import Mixture, NormalMixture
from pymc.distributions.multivariate import (
CAR,
Dirichlet,
Expand Down Expand Up @@ -180,7 +180,6 @@
"SkewNormal",
"Mixture",
"NormalMixture",
"MixtureSameFamily",
"Triangular",
"DiscreteWeibull",
"Gumbel",
Expand Down
1 change: 1 addition & 0 deletions pymc/distributions/distribution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,7 @@ def __new__(
rv_out = cls.change_size(
rv=rv_out,
new_size=resize_shape,
expand=True,
)

rv_out = model.register_rv(
Expand Down
Loading