Refactoring mixture distributions #4795
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue 4781 that seeks to refactor Mixture distributions.
Here is my ongoing WIP. It may not be great, and I would need some pointers. I am also having trouble managing development on different branches, so irrelevant commits may appear here too.
Questions
comp_dists
as an instance attribute without__init__
?Guidelines on Distribution refactoring available here for any readers of this thread.