Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring mixture distributions #4795

Closed
wants to merge 9 commits into from
Closed

Refactoring mixture distributions #4795

wants to merge 9 commits into from

Conversation

larryshamalama
Copy link
Member

Addressing issue 4781 that seeks to refactor Mixture distributions.

Here is my ongoing WIP. It may not be great, and I would need some pointers. I am also having trouble managing development on different branches, so irrelevant commits may appear here too.

Questions

  • Do I need to create a MixtureRV op?
  • My understanding of Distribution classes is still hazy. How do I set comp_dists as an instance attribute without __init__?

Guidelines on Distribution refactoring available here for any readers of this thread.

@larryshamalama
Copy link
Member Author

Back to the drawing board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants