Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setuptools to >=71.0.4 #9812

Merged
merged 4 commits into from
Jul 20, 2024
Merged

Update setuptools to >=71.0.4 #9812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0926c5
Update setuptools to >=71.0.1
cdce8p Jul 18, 2024
7dfef2b
Remove version restriction
cdce8p Jul 18, 2024
7ecce57
Fix test
cdce8p Jul 18, 2024
135f165
Update setuptools to >=71.0.4
cdce8p Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["setuptools>=66.1"]
requires = ["setuptools>=71.0.4"]
build-backend = "setuptools.build_meta"

[project]
Expand Down
2 changes: 1 addition & 1 deletion requirements_test_min.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ pytest-timeout~=2.3
towncrier~=23.11
requests
# Voluntary for test purpose, not actually used in prod, see #8904
setuptools==41.6.0
setuptools;python_version>='3.12'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of removing the version pin, but can I ask why limit the python version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until 3.12, setuptools was bundled with Python itself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the test dependencie set to this specific version as a regression test (see comment above) I think the threat reported is not applicable in this case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I must manually uninstalled it to reproduce that issue 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the test dependencie set to this specific version as a regression test (see comment above) I think the threat reported is not applicable in this case.

I think so too. It nevertheless is a good idea to install a more modern version of setuptools and not keep the old one around. Especially as everyone has moved on since.

3 changes: 1 addition & 2 deletions tests/functional/r/recursion/recursion_error_3159.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ def initialize_options(self):
def finalize_options(self):
pass

@staticmethod
def run():
def run(self):
print("Do anything")


Expand Down
Loading