-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update classifiers and add python_requires #1754
Conversation
The build fails on Python 3.3 because pytest (or rather py) no longer supports 3.3 because it's EOL. Master also fails for 3.3: https://travis-ci.org/hugovk/pylint/builds/309933274 I've opened #1755 to drop it. |
pylint/__pkginfo__.py
Outdated
'Programming Language :: Python :: 3.5', | ||
'Programming Language :: Python :: 3.6', | ||
'Programming Language :: Python :: Implementation :: CPython', | ||
'Programming Language :: Python :: Implementation :: Jython', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support Jython any longer
.gitignore
Outdated
@@ -20,3 +20,4 @@ debian/pylint.substvars | |||
debian/pylint | |||
.coverage | |||
.coverage.* | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be moved in a global .gitignore
file though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could, but some projects include certain files from the .idea directory and that would interfere with those.
https://intellij-support.jetbrains.com/hc/en-us/articles/206544839
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left just two small comments for you to address before merging this one
I rebased on master to remove the merge conflict, then GitHub decided to close it because the merged #1755 includes this. I'll make a new PR to address review comments. |
Based on versions tested in Travis, AppVeyor and Tox.