Also undeprecate optparse #10215
Merged
Also undeprecate optparse #10215
+16
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream undeprecated it in December (python/cpython#126227)
|
Definitely should've tested this. On it. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
added
False Positive 🦟
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10215 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 175 175
Lines 19056 19056
=======================================
Hits 18264 18264
Misses 792 792
|
|
🤖 Effect of this PR on checked open source code: 🤖 Effect on coverage:
The following messages are no longer emitted:
This comment was generated for commit bb28bf1 |
jacobtylerwalls
approved these changes
Feb 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 2, 2025
(cherry picked from commit acf7705)
|
Thank you! |
jacobtylerwalls
pushed a commit
that referenced
this pull request
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream also undeprecated it in December (python/cpython#126227). Feels a bit weird, and sorry for not noticing this earlier. Hopefully I got the news fragment thing right. I wonder if we should mention that these modules were undeprecated?
Type of Changes
Description
Refs #10211