Richer representation #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for super calls an all those update_events now
Its output toggling can now be directly handled
liamhuber
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes with a representation now use a dictionary for their representations, which is auto-populated by the output (including labels) if not explicitly provided. Meanwhile, the
NodePresentershows only the 0th of these representations by default, and other representations can be turned on and off by toggle.Under the hood there was some refactoring, and the
GenericOutput_Nodehas a slightly nicer control interface.Because a bunch of IO labels were changed on the nodes, saved sessions are missing the new labelling features. Here is an updated session:
test.json.zip
This gives all the infrastructure for closing #56, which just now needs individual nodes to have fancier representations.