Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix port selection #51

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Bugfix port selection #51

merged 2 commits into from
Oct 12, 2022

Conversation

liamhuber
Copy link
Member

I had a super() where I needed a self, so children of HidableWidget weren't using their own _is_at_x_y but rather the parent class'.

I also made ports select only inside their circle instead of the bounding square while here.

@liamhuber liamhuber mentioned this pull request Sep 9, 2022
Closed
Base automatically changed from exec_button to main October 12, 2022 19:24
@liamhuber liamhuber marked this pull request as ready for review October 12, 2022 19:24
@liamhuber liamhuber merged commit 8143063 into main Oct 12, 2022
@liamhuber liamhuber deleted the bugfix_port_selection branch October 12, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liamhuber