Refactor canvas widgets #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a whole separate button for this where matplotlib and NGLView get handled.
Make the function just do what it claims, and move the conditional over to the draw method
Solves a small irritation where you press a display button, switch tabs and press another one, then go back to the original tab and the original button still looks pressed (only until the first redraw, but still annoying)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:Play around withon_double_clickto get it working too (for now probably just on nodes as a shortcut for hitting thedisplaybutton, but I want the infrastructure there and working).Handle the display of the node interface (inputs etc) better. Mostly I want to see it get cleared when the owning node is deleted.No new functionality, justbehind-the-scenes stuff on the pseudo-widgets that live in the canvas. Control flow is handled better by callingon_clickmethods of each of the relevant widgets themselves, and the widget OOP structure is (IMO) a bit clearer and more extensible.New functionality: double clicking on a node deletes it, analogous to how double clicking on empty space places a new node.