Decouple draw and status #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done in update/connected/set_val, so direct access to the .val attribute had to be replaced with function calls.
|
|
The init process for ryven nodes is not sufficiently linear to just do it in __init__...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to dtype and otype checks so that they occur at value updates and connection changes, respectively, instead of during each
draw()call for the graph canvas(!!!!). Adding new nodes can still be quite slow, and creating connections can drag a little (since the otype check is still a little expensive), but now moving nodes around the graph window is new pretty comfortable.I had to lean on the portupdatefunction for part of this, and am currently fighting a side effect where we get into the node output generation even when the node readiness should not allow this.On loading a graph, we're still missing a final node update, e.g. forThis was just an issue with the fact that we used to rely on a live recalculation of the structure dtype readiness, but now it was out-of-date; I split the if-clause and added it back in manually.Lammpswhere theengineno longer gets populated.