Port recommender #164
Merged
Port recommender #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super simple, highlighting always takes precedence and it's just colour white
Suuuuper ugly code. I was worried the nested loop and redraw would be slow, but at least testing on a small (5-node) graph, it's blazing fast still. Will need to refactor and improve the algo later, but this does the job.
|
|
Before the drop-down showed the first list element, but that wasn't actually selected.
Otherwise double-clicking won't work to place the recommended node
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
# Conflicts: # ironflow/model/otypes.py # ironflow/model/port.py # ironflow/nodes/pyiron/atomistics_nodes.py
# Conflicts: # .ci_support/environment.yml # ironflow/nodes/pyiron/atomistics_nodes.py # setup.py
Extend ontology
Example bulk modulus
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you select an input (output) port on the graph, ontologically-valid output (input) ports are highlighted white. Highlighting is cleared when you deselect the port. Under the hood, the
get_downstream_conditionsget_downstream_requirementsport method is used to make sure that the suggestions obey transitive conditions in both I/O and O/I cases.The underlying code is nasty, with nested loops and a canvas redraw call. But at least on my small test graph (5 nodes) it is blazing fast still, so let's kick the can down the road on optimization.