Add a new screen for logging #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't play super nicely with working in a notebook, since it eats up stdout output from other cells too! However, the on/off method is working fine, so you can always switch back to seeing output as normal, and we can always set these flags to False by default later.
Worry about beautiful layouts in a future PR, for now just get this thing scrolling.
|
|
This was referenced Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets stdout re-routed to a screen in the gui. In combination with the ryven logger, errors from the nodes themselves (which are normally supressed/ignored to prevent ryven from crashing when a single node borks) are also available. Default is to activate the ryven logger and shove everything over to this logging widget, but there are toggles on the screen to change both these behaviours.
Addresses elements of #105 and #60