Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous drmaa_wcoredump and drmaa_wtermsig calls #47

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

stverhae
Copy link
Contributor

@stverhae stverhae commented Mar 8, 2017

fixes calls to drmaa_wcoredump and drmaa_wtermsig when the job exited normally to fix error when used with condor libdrmaa lib drmaa specifies these calls are only to be made when the job exited abnormally or signaled.

from the drmaa.h file it is clear this is how these calls are supposet to be treated:

/** Returns the name of the signal that terminated the process if the drmaa_wifsignaled() returned non-zero.*/
  int drmaa_wtermsig (char *signal, size_t signal_len, int stat,
		      char *error_diagnosis, size_t error_diag_len);
/** Evalutes core_dumped to non-zero if status was returned for a job that terminated and core_dumped.*/
  int drmaa_wcoredump (int *core_dumped, int stat, char *error_diagnosis,
		       size_t error_diag_len);

Fixes: #21 drmaa-python wait not playing nice with Condor

… normally to fix error when used with condor libdrmaa lib

drmaa specifies these calls are only to be made when the job exited abnormally or signaled.
@dan-blanchard dan-blanchard merged commit 6f03237 into pygridtools:master Mar 8, 2017
@dan-blanchard dan-blanchard mentioned this pull request Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drmaa-python wait not playing nice with Condor
2 participants