Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic common support #19

Merged
merged 4 commits into from
Feb 24, 2024
Merged

Add basic common support #19

merged 4 commits into from
Feb 24, 2024

Conversation

Vipitis
Copy link
Collaborator

@Vipitis Vipitis commented Jan 26, 2024

part of #4 (mainly in preparation for adding Buffers A-C, audio shaders and loading form API eventually)

The common tab (sometimes called renderpass by me due to API key-naming) is essentially a shared "library" of functions and variables across the different buffers (including default/image). Information can be found here

The implementation simply puts it between the combability code and the shader_code which might not be correct in all cases
So more stuff to check before this is ready:

  • test wgsl
  • test macros and builtins (according to the blog post)
  • better examples

@Vipitis Vipitis marked this pull request as ready for review February 20, 2024 20:24
@Vipitis Vipitis requested a review from Korijn February 24, 2024 20:49
Copy link
Contributor

@Korijn Korijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vipitis Vipitis merged commit 455f495 into main Feb 24, 2024
11 checks passed
@Vipitis Vipitis deleted the add-common branch February 24, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants