Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mixer documentation #3228

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

GabrieleLS
Copy link
Contributor

Resolution of confusion in the documentation between the channels argument in the mixer init, and the playback channels (used for exemple in the function "set_num_channels" and "get_num_channels").

Related to issue #3184.

@GabrieleLS GabrieleLS requested a review from a team as a code owner November 20, 2024 08:15
Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zoldalma999
Copy link
Member

CI is failing because there's an extra space on line 82 and 83 at the end of the line ("to the number " and "with the function ")

Modification to pass the checks.
@GabrieleLS
Copy link
Contributor Author

Thanks, I fixed it.

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing 🎉

@ankith26 ankith26 added this to the 2.5.3 milestone Nov 20, 2024
@ankith26 ankith26 merged commit 3b850e7 into pygame-community:main Nov 20, 2024
2 checks passed
@yunline yunline added docs mixer pygame.mixer labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs mixer pygame.mixer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants