Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement openapi 3.0 specification. #70

Closed
wants to merge 2 commits into from
Closed

Conversation

rmlopes
Copy link
Contributor

@rmlopes rmlopes commented Jun 29, 2018

Plus:
Add sub-resource path parameters documentation.
Add security definitions for eve-oauth extension.
Use resource example only for requestBody parameters (responses use the schema based example).
Add reusable IfMatch parameter.

Open to discussion.

rmlopes added 2 commits June 29, 2018 17:34
… documentation. Add security definitions for eve-oauth extension. Use resource example only for requestBody parameters (responses use the schema based example).
@stale
Copy link

stale bot commented Jan 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@sergekir
Copy link

Any plans on merging it?

@nicolaiarocci
Copy link
Member

Yes, I plan on reviewing this (and other stuff) once I have some extra time to work on the eve ecosystem.

@nicolaiarocci
Copy link
Member

Howdy!

I am sorry for the long wait @rmlopes and @sergekir. Since some time has passed, do any of you have anything to add/comment about this pull request?

@rmlopes
Copy link
Contributor Author

rmlopes commented Mar 29, 2019

Hi Nicola,

I have kept a branch for this PR and in the meanwhile have made other improvements that I needed for my project. These included support for the valueschema properties and support for static documentation using redoc. I just merged them into master this morning and I can create another PR for comparison if you wish. I think it is still pertinent whether this should be an upgrade for eve-swagger or rather a new extension.

EDIT: not sure what is going on with the flake8 test, it is returning an error at the email regex on validation.py, but it is successful when I run it on my machine.

@rmlopes rmlopes closed this Mar 29, 2019
@rmlopes rmlopes reopened this Mar 29, 2019
@nicolaiarocci
Copy link
Member

Please submit a new PR, I will gladly review it.

@nicolaiarocci
Copy link
Member

@rmlopes ping, just to make sure work is still ongoing here.

@rmlopes rmlopes mentioned this pull request Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants