Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataArray does not have the _data attribute #7967

Closed
wants to merge 1 commit into from

Conversation

cyschneck
Copy link

@welcome
Copy link

welcome bot commented Jul 9, 2023

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

@kmuehlbauer
Copy link
Contributor

Related open issue over at geocat: NCAR/geocat-comp#381

@Illviljan Illviljan added the run-benchmark Run the ASV benchmark workflow label Jul 9, 2023
@Illviljan
Copy link
Contributor

Why are you sending a DataArray to this function that only accepts Variables?

Looking at the error in #7966. If you want to continue using non-public functions, change

xr.core.common.contains_cftime_datetimes(d_arr)

to this

xr.core.common.contains_cftime_datetimes(d_arr.variable)

@cyschneck cyschneck closed this Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmark Run the ASV benchmark workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataArray throws error in contains_cftime_datetimes() -> _data vs data (with fix?)
3 participants