Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example using Coarsen.construct to split map into regions #7192

Merged
merged 6 commits into from
Oct 21, 2022

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented Oct 20, 2022

I realised there is very little documentation on Coarsen.construct, so I added this example.

Unsure whether it should instead live in the page on reshaping and reorganising data though, as it is essentially a reshape operation. EDIT: Now on the reshape page

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

cc @jbusecke @paigem

@dcherian
Copy link
Contributor

Unsure whether it should instead live in the page on reshaping and reorganising data though, as it is essentially a reshape operation.

This would be good IMO

doc/whats-new.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomNicholas

LGTM as long as it renders nicely.

@TomNicholas
Copy link
Member Author

TomNicholas commented Oct 21, 2022

LGTM as long as it renders nicely.

It renders nicely locally, but any idea why the RTD build fails so opaquely?

@dcherian
Copy link
Contributor

/home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/7192/doc/whats-new.rst:2999: WARNING: undefined label: comput.coarsen
/home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/7192/doc/whats-new.rst:3054: WARNING: undefined label: comput.coarsen

We fail in warnings in RTD

@TomNicholas TomNicholas merged commit 6cb97f6 into pydata:main Oct 21, 2022
@TomNicholas TomNicholas deleted the coarsen_construct_example branch October 21, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants