rely on numpy
's version of nanprod
and nansum
#6873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment,
nanprod
andnansum
will replace anynan
values with1
fornanprod
or0
fornansum
. Forpint
, inserting dimensionless values into quantities is explicitly not allowed, so our version ofnanprod
cannot be used onpint
quantities (0
is a exception sonansum
does work).I'm proposing to rely on
numpy
's version for that, which would allowpint
to customize the behavior.