-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pickling issue #6249
Fix pickling issue #6249
Conversation
Any idea why the pipeline is broken ? |
That's unrelated to this PR, you can safely ignore it.
Edit: see #6250 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @antarcticrainforest! I think this may be the best we can do in terms of a solution for now.
It's great that you added an integration test using distributed, since we've had issues like this crop up before. Maybe you could also add a pickling test within test_cftimeindex.py
similar to @mathause's example, and a what's new entry as well?
Okidoke I've added a test for pickling cftimeindex objects and updated the whats-new document. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me -- just a minor cleanup suggestion for the what's-new entry.
Co-authored-by: Spencer Clark <[email protected]>
Co-authored-by: Spencer Clark <[email protected]>
for more information, see https://pre-commit.ci
thanks @antarcticrainforest and welcome to xarray! |
This PR tries to address some updates in the pandas library on how datetime objects are pickled. Since I was told that the datatype of the CFtimeIndex object will always be
object
I just instructed the__new__
method to receive any additional arguments but not to evaluate them. Which feels a little awkward but does the job. If there are better ways to deal with this please let me know. @spencerkclark @aidanheerdegen @mathause