Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.10 to CI #5844

Merged
merged 19 commits into from
Jan 21, 2022
Merged

Add python 3.10 to CI #5844

merged 19 commits into from
Jan 21, 2022

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Oct 7, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

Unit Test Results

         6 files           6 suites   55m 24s ⏱️
16 290 tests 14 522 ✔️ 1 768 💤 0
90 936 runs  82 551 ✔️ 8 385 💤 0

Results for commit 043b32a.

♻️ This comment has been updated with latest results.

@Illviljan Illviljan closed this Oct 9, 2021
@Illviljan Illviljan reopened this Oct 9, 2021
@Illviljan
Copy link
Contributor Author

Mamba seems to have troubles installing python 3.10 for some reason.
Maybe just waiting a little bit longer and letting the new version settle will do it?

@keewis
Copy link
Collaborator

keewis commented Oct 9, 2021

Maybe just waiting a little bit longer and letting the new version settle will do it?

I guess so... when upgrading CI to 3.9 we had to wait pretty long until numba supported it, too (at least until February it was March), and I doubt they will be any quicker this time. We might be able to do a partial test (i.e. without installing numbagg), though.

@Illviljan
Copy link
Contributor Author

Might be something else now then numbaagg. I think I turned off numbaagg now and i still got these cryptic errors:

  Looking for: ['python=3.10']
  
  Encountered problems while solving:
    - package python-3.10.0-h62f1059_0_cpython requires pip, but none of the providers can be installed
  
  pkgs/main/noarch          
  pkgs/r/linux-64           
  pkgs/r/noarch             
  pkgs/main/linux-64        
  conda-forge/noarch        
  conda-forge/linux-64     

@keewis
Copy link
Collaborator

keewis commented Oct 9, 2021

that's to be expected, I guess, python=3.10 is still pretty new. In this case there's a bug in conda's parsing of python versions (it assumes single-digit minor versions) which somehow results in broken noarch packages. We'll probably have to wait until either python-feedstock merged a workaround or conda fixed the bug. Given that there's open PRs for both that should hopefully be soon.

@Illviljan
Copy link
Contributor Author

Looking for: ['aiobotocore', 'boto3', 'bottleneck', 'cartopy', 'cdms2', 'cfgrib', 'cftime', 'dask', 'distributed', 'fsspec!=2021.7.0', 'h5netcdf', 'h5py', 'hdf5', 'hypothesis', 'iris', 'lxml', 'matplotlib-base', 'nc-time-axis', 'netcdf4', 'numba', 'numexpr', 'numpy', 'pandas', 'pint', 'pip', 'pooch', 'pre-commit', 'pseudonetcdf', 'pydap', 'pytest', 'pytest-cov', 'pytest-env', 'pytest-xdist', 'rasterio', 'scipy', 'seaborn', 'setuptools', 'sparse', 'toolz', 'typing_extensions', 'zarr']


Encountered problems while solving:
  - package rasterio-1.1.7-py39h645c05b_1 requires python >=3.9,<3.10.0a0, but none of the providers can be installed

rasterio doesn't allow 3.10?

@Illviljan
Copy link
Contributor Author

Codecov seems to take a while:

   Codecov report uploader 0.1.15
[2022-01-19T21:20:41.230Z] ['info'] => Project root located at: /Users/runner/work/xarray/xarray
[2022-01-19T21:20:41.236Z] ['info'] -> No token specified or token is empty
[2022-01-19T21:20:41.246Z] ['info'] Searching for coverage files...
[2022-01-19T21:20:41.281Z] ['info'] => Found 1 possible coverage files:
  ./coverage.xml
[2022-01-19T21:20:41.282Z] ['info'] Processing ./coverage.xml...
[2022-01-19T21:20:41.294Z] ['info'] Detected GitHub Actions as the CI provider.
[2022-01-19T21:20:41.296Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-2.1.0-uploader-0.1.15&token=*******&branch=python310&build=1720207030&build_url=https%3A%2F%2Fgithub.jparrowsec.cn%2Fpydata%2Fxarray%2Factions%2Fruns%2F1720207030&commit=a4f32ed728765145eedf727c98a9e7aef26049c0&job=CI&pr=5844&service=github-actions&slug=pydata%2Fxarray&name=codecov-umbrella&tag=&flags=unittests&parent=
[2022-01-19T21:20:53.209Z] ['info'] Uploading...

How important is it?

@Illviljan Illviljan marked this pull request as ready for review January 19, 2022 21:25
@Illviljan
Copy link
Contributor Author

I think this is ready now. Only had to temporarily comment out pydap until it supports 3.10.

@Illviljan Illviljan added plan to merge Final call for comments and removed needs review labels Jan 20, 2022
@Illviljan
Copy link
Contributor Author

Merging, thanks!

@Illviljan Illviljan merged commit 10855dc into pydata:main Jan 21, 2022
@Illviljan Illviljan deleted the python310 branch August 12, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants