Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip-ci] Add @Illviljan to core team #5813

Merged
merged 1 commit into from
Sep 24, 2021
Merged

[skip-ci] Add @Illviljan to core team #5813

merged 1 commit into from
Sep 24, 2021

Conversation

dcherian
Copy link
Contributor

No description provided.

@dcherian dcherian requested a review from andersy005 September 23, 2021 23:44
@max-sixty
Copy link
Collaborator

Congrats and welcome @Illviljan !

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2021 •
edited
Loading

Unit Test Results

         6 files  ±0           6 suites  ±0   1h 2m 12s ⏱️ ±0s
16 227 tests ±0  14 492 ✔️ ±0  1 735 💤 ±0  0 ❌ ±0 
90 558 runs  ±0  82 384 ✔️ ±0  8 174 💤 ±0  0 ❌ ±0 

Results for commit ed94afb. ± Comparison against base commit ed94afb.

♻️ This comment has been updated with latest results.

@Illviljan
Copy link
Contributor

Thanks! :)

andersy005
andersy005 approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Welcome 🎉 @Illviljan

@andersy005
Copy link
Member

andersy005 commented Sep 24, 2021 •
edited
Loading

Readthedocs build is failing due to timeout. It appears that our doc builds have been failing for the last few hours, and my hunch is that somehow we are exceeding the 15 minutes build time limit for some PRs

Screen Shot 2021-09-24 at 1 35 41 PM

@dcherian dcherian merged commit ed94afb into main Sep 24, 2021
@andersy005 andersy005 deleted the illviljan branch September 24, 2021 19:39
snowman2 pushed a commit to snowman2/xarray that referenced this pull request Feb 9, 2022
@dcherian @snowman2
Add @Illviljan to core team (pydata#5813)
ec0d1af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcherian @max-sixty @Illviljan @andersy005