-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xr.unify_chunks()
top level method
#5445
Conversation
pinging @dcherian and/or @crusaderky who may have thoughts on this PR. |
Co-authored-by: crusaderky <[email protected]>
Co-authored-by: crusaderky <[email protected]>
Co-authored-by: crusaderky <[email protected]>
Co-authored-by: crusaderky <[email protected]>
Co-authored-by: crusaderky <[email protected]>
Co-authored-by: crusaderky <[email protected]>
Co-authored-by: crusaderky <[email protected]>
Co-authored-by: crusaderky <[email protected]>
Co-authored-by: crusaderky <[email protected]>
Co-authored-by: crusaderky <[email protected]>
… into add_unify_chunks
Co-authored-by: crusaderky <[email protected]>
Thanks @crusaderky! I think all your suggestions are now implemented. |
LGTM. a = DataArray([0,1,2,3], dims=["x"], coords={"x": [0,10,20,30]}).chunk(3)
b = DataArray([0,1,2,3], dims=["x"], coords={"x": [10,30,40,50]}).chunk(2)
a, b = unify_chunks(a, b) You'll end up with aligned chunks, but not aligned coords (e.g. both outputs have still values=[0,1,2,3]), which doesn't make much sense. |
Ya I think it's OK for this function |
Thanks @malmans2 and @crusaderky! |
pre-commit run --all-files
whats-new.rst
api.rst