Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document restrictions to the inline repr #4912

Merged
merged 6 commits into from
Feb 17, 2021
Merged

document restrictions to the inline repr #4912

merged 6 commits into from
Feb 17, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Feb 16, 2021

As suggested in #4248, this asks not to include shape and dtype in _repr_inline_ implementations and shows sparse and dask reprs as examples.

max-sixty
max-sixty approved these changes Feb 16, 2021
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@keewis
Copy link
Collaborator Author

keewis commented Feb 17, 2021

thanks for the reviews, @dcherian, @max-sixty.

@keewis keewis merged commit 9858a27 into pydata:master Feb 17, 2021
@keewis keewis deleted the document-repr_inline branch February 17, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keewis @dcherian @max-sixty