Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speedup attribute style access and tab completion #4742

Merged
merged 3 commits into from
Jan 5, 2021
Merged

speedup attribute style access and tab completion #4742

merged 3 commits into from
Jan 5, 2021

Conversation

rhkleijn
Copy link
Contributor

@rhkleijn rhkleijn commented Dec 30, 2020 •
edited
Loading

  • Closes Attribute style access is slow #4741

  • Passes isort . && black . && mypy . && flake8

  • User visible changes (including notable bug fixes) are documented in whats-new.rst

  • make _attr_sources and _item_sources lazy

  • make lookup of virtual dimension coordinates lazy

  • make helper class more general so it can be used for lookup of both virtual dimension and level coordinates

@dcherian dcherian mentioned this pull request Dec 30, 2020
Open
19 tasks
mathause
mathause approved these changes Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as far as I understand it)

@max-sixty
Copy link
Collaborator

Looks great, thanks @rhkleijn

dcherian
dcherian reviewed Jan 4, 2021
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using _coords and _coord_names should improve performance a little more

shoyer
shoyer approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@mathause mathause merged commit 7298df0 into pydata:master Jan 5, 2021
@mathause
Copy link
Collaborator

mathause commented Jan 5, 2021

Thanks @rhkleijn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian left review comments

@max-sixty max-sixty max-sixty left review comments

@shoyer shoyer shoyer approved these changes

@mathause mathause mathause approved these changes

Assignees
No one assigned
Labels
topic-performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attribute style access is slow
5 participants
@rhkleijn @max-sixty @mathause @shoyer @dcherian