Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct users to GitHub discussions page for usage questions #4578

Merged
merged 10 commits into from
Nov 25, 2020

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Nov 12, 2020

Towards #4549

  • Closes #xxxx
  • Tests added
  • Passes isort . && black . && mypy . && flake8
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

url: https://github.com/pydata/xarray/discussions
about: Ask questions and discuss with other community members here.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify the reproducible examples here, or is there a separate template for discussions?

Comment on lines 6 to 8
If you have a question like `How do I concatenate a list of datasets?` then
please include a self-contained reproducible example if possible.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-sixty, let me know if this enough and/or whether this is what you are suggesting in

Should we specify the reproducible examples here, or is there a separate template for discussions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes great! I'm not sure if we can fit the link we generally use https://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports, so probably we go with this and add the link when we can have a standard discussion template.

Thanks!

Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @andersy005, looks good to me. I'd change the backticks (see below), but other than that I think we can merge (and add the "reproducible example" link once discussion templates become available)

@keewis
Copy link
Collaborator

keewis commented Nov 24, 2020

thanks for the quick update, @andersy005. If there are no further comments: let's merge?

@andersy005
Copy link
Member Author

thanks for the quick update, @andersy005. If there are no further comments: let's merge?

I think this is ready to be merged...

@keewis
Copy link
Collaborator

keewis commented Nov 25, 2020

oh, yes, I just wanted to give others the opportunity to comment before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants