Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin eccodes again #4525

Merged
merged 1 commit into from
Oct 19, 2020
Merged

unpin eccodes again #4525

merged 1 commit into from
Oct 19, 2020

Conversation

mathause
Copy link
Collaborator

That was fast - eccodes already fixed the issue.

keewis
keewis approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @mathause. The failing upstream-dev tests are unrelated (#4516, I think).

@mathause
Copy link
Collaborator Author

yup, thats #4516

@dcherian dcherian merged commit 2ce1cfc into pydata:master Oct 19, 2020
@dcherian
Copy link
Contributor

Thanks @mathause

@mathause mathause deleted the unpin_eccodes branch October 18, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cfgrib does not work with newest eccodes version
3 participants
@mathause @dcherian @keewis