Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoding year 1 time #4506

Merged
merged 16 commits into from
Oct 26, 2020
Merged

Decoding year 1 time #4506

merged 16 commits into from
Oct 26, 2020

Conversation

znicholls
Copy link
Contributor

@znicholls znicholls commented Oct 13, 2020 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Oct 13, 2020 •
edited
Loading

Hello @znicholls! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-26 08:13:15 UTC

@znicholls znicholls marked this pull request as ready for review October 13, 2020 06:27
@znicholls
Copy link
Contributor Author

I am not sure what is causing the CI failure, I don't think it's related to my changes

@max-sixty
Copy link
Collaborator

Hi @znicholls — thanks for your PR, and welcome to xarray!

We've had a recent issue with an upstream change, so that is likely the cause of the error.

The PR LGTM, though I'll let those who know this area of the code better review it.

spencerkclark
spencerkclark reviewed Oct 18, 2020
View reviewed changes
Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @znicholls! This is a really nice fix.

@znicholls znicholls force-pushed the decoding-year-1-time branch from f6f877a to d9240d4 Compare October 19, 2020 22:31
mathause
mathause reviewed Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some nits - feel free to ignore them.

@mathause
Copy link
Collaborator

The failure is unrelated, so I'll go ahead and merge. Thanks @znicholls and welcome to xarray!

@mathause mathause merged commit adc55ac into pydata:master Oct 26, 2020
@znicholls
Copy link
Contributor Author

Wicked thanks everyone!

@znicholls znicholls deleted the decoding-year-1-time branch October 26, 2020 10:15
@mathause mathause mentioned this pull request Nov 18, 2020
Merged
@albertotb albertotb mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian left review comments

@mathause mathause mathause left review comments

@spencerkclark spencerkclark spencerkclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem decoding times in data from OpenDAP server
6 participants
@znicholls @pep8speaks @max-sixty @mathause @dcherian @spencerkclark