Silence plot warnings #4365
Merged
Silence plot warnings #4365
+91
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
approved these changes
Aug 21, 2020
dcherian
reviewed
Aug 21, 2020
| @@ -291,6 +291,11 @@ def _determine_cmap_params( | |||
| cmap, newnorm = _build_discrete_cmap(cmap, levels, extend, filled) | |||
| norm = newnorm if norm is None else norm | |||
|
|
|||
| # vmin & vmax needs to be None if norm is passed | |||
There was a problem hiding this comment.
I wonder if we can cleanup this function a bit by always returning a norm with vmin, vmax specified. But that can be a future PR.
There was a problem hiding this comment.
Yes that would be nice. I did not know which the default norm would be...
There was a problem hiding this comment.
I think the default is mpl.colors.Normalize.
mathause
commented
Aug 21, 2020
|
Nice! Thanks a lot @mathause |
keewis
reviewed
Aug 21, 2020
keewis
reviewed
Aug 21, 2020
|
the upstream-dev CI failure seems to be caused by |
|
I switched to I'll leave the |
|
Thanks @mathause |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && mypy . && flake8whats-new.rstI gave a try to silence some of the warning for the plotting functions. I brought it down from 67 to 5 (4 of which come from external libraries).
MatplotlibDeprecationWarning: The 'extend' parameter to Colorbar has no effect because it is overridden by the mappable; it is deprecated since 3.3 and will be removed two minor releases later.MatplotlibDeprecationWarning: You are modifying the state of a globally registered colormap. In future versions, you will not be able to modify a registered colormap in-place. To remove this warning, you can make a copy of the colormap first. cmap = copy.copy(mpl.cm.get_cmap("viridis"))MatplotlibDeprecationWarning: Passing parameters norm and vmin/vmax simultaneously is deprecated since 3.3 and will become an error two minor releases later. Please pass vmin/vmax directly to the norm when creating it.MatplotlibDeprecationWarning: shading='flat' when X and Y have the same dimensions as C is deprecated since 3.3. Either specify the corners of the quadrilaterals with X and Y, or pass shading='auto', 'nearest' or 'gouraud', or set rcParams['pcolor.shading']. This will become an error two minor releases later.See plt.pcolormesh will infer interval breaks per default #4364UserWarning: Requested projection is different from current axis projection, creating new axis with requested projection.I cannot exclude that one of these changes has an effect on the plots that is not tested in the suite... Tests pass locally for py38 and py36-bare-minimum.