Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify drop_vars return value. #4244

Merged
merged 4 commits into from
Aug 14, 2020
Merged

Clarify drop_vars return value. #4244

merged 4 commits into from
Aug 14, 2020

Conversation

rpgoldman
Copy link
Contributor

The previous documentation was not clear about whether the variable
dropping was "inplace" or created a fresh Dataset.

@rpgoldman
Clarify drop_vars return value.
ee6e93b 
The previous documentation was not clear about whether the variable
dropping was "inplace" or created a fresh Dataset.
max-sixty
max-sixty reviewed Jul 25, 2020
View reviewed changes
max-sixty
max-sixty reviewed Jul 25, 2020
View reviewed changes
@max-sixty
Copy link
Collaborator

Thanks @rpgoldman !

What do you think of that change? Feel free to discard if you disagree and we'll merge your initial suggestion.

@rpgoldman
Copy link
Contributor Author

Thanks @rpgoldman !

What do you think of that change? Feel free to discard if you disagree and we'll merge your initial suggestion.

How about we keep your sentence which is much better than my first sentence, and my second sentence? I think it's important to make the point that this function does not have side effects.

Any idea why the docs build failed?

@keewis
Copy link
Collaborator

keewis commented Jul 26, 2020

Any idea why the docs build failed?

that has been fixed in #4254 so merging master should be enough.

rpgoldman and others added 3 commits July 26, 2020 08:46
@rpgoldman @max-sixty
Update xarray/core/dataarray.py
7a5168d 
Fix syntax error in docstring markdown.

Co-authored-by: Maximilian Roos <[email protected]>
@dcherian @max-sixty
Update xarray/core/dataarray.py
5641c35 
Co-authored-by: Maximilian Roos <[email protected]>
@dcherian
Merge branch 'master' of github.com:pydata/xarray into drop-vars-doc
f648f41 
* 'master' of github.com:pydata/xarray: (260 commits)
  Increase support window of all dependencies (pydata#4296)
  Implement interp for interpolating between chunks of data (dask) (pydata#4155)
  Add @mathause to current core developers. (pydata#4335)
  install sphinx-autosummary-accessors from conda-forge (pydata#4332)
  Use sphinx-accessors-autosummary (pydata#4323)
  ndrolling fixes (pydata#4329)
  DOC: fix typo argmin -> argmax in DataArray.argmax docstring (pydata#4327)
  pin sphinx to 3.1(pydata#4326)
  nd-rolling (pydata#4219)
  Implicit dask import 4164 (pydata#4318)
  allow customizing the inline repr of a duck array (pydata#4248)
  silence the known docs CI issues (pydata#4316)
  enh: fixed pydata#4302 (pydata#4315)
  Remove all unused and warn-raising methods from AbstractDataStore (pydata#4310)
  Fix map_blocks example (pydata#4305)
  Fix docstring for missing_dims argument to isel methods (pydata#4298)
  Support for PyCharm remote deployment (pydata#4299)
  Update map_blocks and map_overlap docstrings (pydata#4303)
  Lazily load resource files (pydata#4297)
  warn about the removal of the ufuncs (pydata#4268)
  ...
@max-sixty max-sixty merged commit 38b0144 into pydata:master Aug 14, 2020
@max-sixty
Copy link
Collaborator

I realize that we may have lost a sentence through the merges; maybe someone clicked on apply suggestion to apply my suggestion. To the extent that wasn't your intention @rpgoldman lmk and I'll add back

dcherian added a commit to dcherian/xarray that referenced this pull request Aug 15, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into propagate-attrs
b86623c 
* upstream/master: (34 commits)
  Fix bug in computing means of cftime.datetime arrays (pydata#4344)
  fix some str accessor inconsistencies (pydata#4339)
  pin matplotlib in ci/requirements/doc.yml (pydata#4340)
  Clarify drop_vars return value. (pydata#4244)
  Support explicitly setting a dimension order with to_dataframe() (pydata#4333)
  Increase support window of all dependencies (pydata#4296)
  Implement interp for interpolating between chunks of data (dask) (pydata#4155)
  Add @mathause to current core developers. (pydata#4335)
  install sphinx-autosummary-accessors from conda-forge (pydata#4332)
  Use sphinx-accessors-autosummary (pydata#4323)
  ndrolling fixes (pydata#4329)
  DOC: fix typo argmin -> argmax in DataArray.argmax docstring (pydata#4327)
  pin sphinx to 3.1(pydata#4326)
  nd-rolling (pydata#4219)
  Implicit dask import 4164 (pydata#4318)
  allow customizing the inline repr of a duck array (pydata#4248)
  silence the known docs CI issues (pydata#4316)
  enh: fixed pydata#4302 (pydata#4315)
  Remove all unused and warn-raising methods from AbstractDataStore (pydata#4310)
  Fix map_blocks example (pydata#4305)
  ...
dcherian added a commit to dcherian/xarray that referenced this pull request Aug 16, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into fix/4107
1ea8666 
* upstream/master: (40 commits)
  Fix bug in computing means of cftime.datetime arrays (pydata#4344)
  fix some str accessor inconsistencies (pydata#4339)
  pin matplotlib in ci/requirements/doc.yml (pydata#4340)
  Clarify drop_vars return value. (pydata#4244)
  Support explicitly setting a dimension order with to_dataframe() (pydata#4333)
  Increase support window of all dependencies (pydata#4296)
  Implement interp for interpolating between chunks of data (dask) (pydata#4155)
  Add @mathause to current core developers. (pydata#4335)
  install sphinx-autosummary-accessors from conda-forge (pydata#4332)
  Use sphinx-accessors-autosummary (pydata#4323)
  ndrolling fixes (pydata#4329)
  DOC: fix typo argmin -> argmax in DataArray.argmax docstring (pydata#4327)
  pin sphinx to 3.1(pydata#4326)
  nd-rolling (pydata#4219)
  Implicit dask import 4164 (pydata#4318)
  allow customizing the inline repr of a duck array (pydata#4248)
  silence the known docs CI issues (pydata#4316)
  enh: fixed pydata#4302 (pydata#4315)
  Remove all unused and warn-raising methods from AbstractDataStore (pydata#4310)
  Fix map_blocks example (pydata#4305)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpgoldman @max-sixty @keewis @dcherian