Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cftime frequency strings in line with recent updates in pandas #8394

Closed
spencerkclark opened this issue Oct 31, 2023 · 1 comment · Fixed by #8415
Closed

Update cftime frequency strings in line with recent updates in pandas #8394

spencerkclark opened this issue Oct 31, 2023 · 1 comment · Fixed by #8415

Comments

@spencerkclark
Copy link
Member

spencerkclark commented Oct 31, 2023

What is your issue?

Pandas has introduced some deprecations in how frequency strings are specified:

It would be good to carry these deprecations out for cftime frequency specifications to remain consistent.

@spencerkclark spencerkclark added needs triage Issue that has not been reviewed by xarray team member topic-cftime labels Oct 31, 2023
@dcherian dcherian removed the needs triage Issue that has not been reviewed by xarray team member label Oct 31, 2023
@aulemahal
Copy link
Contributor

That's quite heavy a change... This move from pandas seems an unnecessary leap to me!
I'll look into the PR, thanks for heads up!

Zeitsperre added a commit to bird-house/finch that referenced this issue Dec 5, 2023
## Overview

Changes:

* Added pins to xarray and pandas to prevent issues with breaking
changes.
* Fixed an error with a cftime index fixing function.
* Switched `bump2version` for `bump-my-version`
* Do not fail when running pip check in conda environments

## Related Issue / Discussion

Ouranosinc/xclim#1534
pydata/xarray#8394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants