Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of a vertical scroll bar as a result of rtd-footer-container on none RTD hosted sites #1794

Closed
andrewcoughtrie opened this issue Apr 29, 2024 · 1 comment · Fixed by #2034
Closed

Addition of a vertical scroll bar as a result of rtd-footer-container on none RTD hosted sites #1794

andrewcoughtrie opened this issue Apr 29, 2024 · 1 comment · Fixed by #2034
Labels
kind: bug Something isn't working

Comments

@andrewcoughtrie
Copy link

andrewcoughtrie commented Apr 29, 2024 •
edited
Loading

When hosting on a none RTD site (specifically on GitHub pages in this case) the addition of the rtd-footer-container results in a scroll bar on the primary sidebar even when the length of the list is significantly shorter than the page. Modifying the html of the page and removing the rtd-footer-container fixes this behavior.
@andrewcoughtrie andrewcoughtrie changed the title Additional vertical scroll bar as a result of rtd-footer-container on none RTD hosted sites Addition of a vertical scroll bar as a result of rtd-footer-container on none RTD hosted sites Apr 29, 2024
@drammock
Copy link
Collaborator

thanks for reporting. I think that div is supposed to be suppressed if it's empty, so the fact that it still shows up is definitely something we should fix. (or if we're not trying to suppress it, then we should be!)

@drammock drammock mentioned this issue May 3, 2024
Open
@trallard trallard added the kind: bug Something isn't working label May 24, 2024
This was referenced Oct 11, 2024
Open
Closed
@gabalafou gabalafou mentioned this issue Nov 11, 2024
Merged
Carreau pushed a commit that referenced this issue Nov 12, 2024
@gabalafou
Stop moving the Read the Docs version switcher into the sidebar (#2034)
92f5110 
Read the Docs recently rolled out its new "addons" project. This broke
assumptions made by code in our theme.

In particular, it means that all of the code that tries to move the Read
the Docs version switcher into the sidebar no longer works, so this pull
request removes all of that code and updates the docs.

I also removed the check for Read the Docs in the Ethical Ads template
because as far as I understand, that template is opt-in anyway, meaning
that sites that use our theme do not have that template included by
default.

Fixes #1794 and
possibly #1238.

This pull request does not address
#1933, which is
about providing a better integration with Read the Docs. The only goal
of this pull request is to remove code that is broken as a result of the
addons rollout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@drammock @trallard @andrewcoughtrie