fix: discriminator key used when discriminator has alias and .schema(by_alias=False)
#10146
+175
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
|
@sydney-runkle FYI! |
|
not too sure why the |
sydney-runkle
approved these changes
Aug 15, 2024
|
@exs-dwoodward, yeah, a bit odd. Seems like this was fixed in #10139. |
15 tasks
sydney-runkle
changed the title
.schema(by_alias=False)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes an issue in pydantic v1 whereby a discriminated union model where the discriminated field has an alias does not get the field name propagated to the schema's
discriminator.propertyNamewhen the model has.schema(by_alias=False)called.Related issue number
fix #10131
skip change file check
Checklist
skip file change check
Selected Reviewer: @samuelcolvin