Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asynchronous CLI methods in CliApp #533

Merged
merged 6 commits into from
Feb 19, 2025
Merged

Asynchronous CLI methods in CliApp #533

merged 6 commits into from
Feb 19, 2025

Conversation

KanchiShimono
Copy link
Contributor

Resolves #531

hyperlint-ai[bot]
hyperlint-ai bot reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • Pydantic

@hramezani
Copy link
Member

Thanks @KanchiShimono for this PR.

@kschwab Do you have time to review this PR?

kschwab
kschwab approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@kschwab kschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramezani @KanchiShimono looks good to me 👍🏾

hramezani
hramezani reviewed Feb 19, 2025
View reviewed changes
hyperlint-ai[bot]
hyperlint-ai bot reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • cli_cmd
  • [Aa]sync
  • [Ss]ubcommands
  • [Ss]ubcommand
  • Pydantic

@hramezani
Copy link
Member

Thanks @KanchiShimono, @kschwab

@hramezani hramezani merged commit 7835118 into pydantic:main Feb 19, 2025
23 checks passed
@KanchiShimono KanchiShimono deleted the async-cli-command branch February 19, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperlint-ai hyperlint-ai[bot] hyperlint-ai[bot] left review comments

@hramezani hramezani hramezani approved these changes

@kschwab kschwab kschwab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Support asynchronous CLI methods in CliApp
3 participants
@KanchiShimono @hramezani @kschwab