extract vs cast_as
#2
Conversation
| @@ -101,9 +101,9 @@ pub fn validate_str_recursive<'py>( | |||
| to_lower: bool, | |||
| to_upper: bool, | |||
| ) -> PyResult<&'py PyAny> { | |||
| if let Ok(list) = value.cast_as::<PyList>() { | |||
There was a problem hiding this comment.
Can reproduce this locally and it turns out that exactly these two calls to extract make the difference. (The other ones above do not.)
(It would be nice to loose the second here to keep this PR focused on the extract-vs-cast-as issue.)
There was a problem hiding this comment.
thanks so much for looking into it.
Is there anything I can do to help here?
On balance, to avoid profiling every change, I guess I'd prefer to use cast_as where possible - I feels more semantically correct and AFAIK it's never slower (???). So I'll just close this PR.
There was a problem hiding this comment.
I have reproduced the problem in an isolated PyO3 benchmark now. So I think you can close this and also revoke my access to the repository. Everything else will need to be handled in the PyO3 repository.
|
Closing this as there's more detail on PyO3/pyo3#2278. Thanks for your help. |
Confusingly this PR is going from fast to slow.
Performance (from running
python benchmarks/run.py):With
cast_as:With
extract:@adamreichold in case this helps.