Use core schema fns to initalize SchemaValidators in the test suite.
#1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1631 +/- ##
==========================================
- Coverage 90.21% 89.58% -0.63%
==========================================
Files 106 115 +9
Lines 16339 17905 +1566
Branches 36 25 -11
==========================================
+ Hits 14740 16040 +1300
- Misses 1592 1846 +254
- Partials 7 19 +12 see 66 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #1631 will not alter performanceComparing Summary
|
mikeedjones
force-pushed
the
chore/use-core_schema-fn-to-initalize-validators
branch
from
37d4e29 to
3fa5d10
Compare
mikeedjones
changed the title
mikeedjones
changed the title
|
To track which Validatorstests/test_misc.py
tests/test_build.py
tests/test_json.py
tests/test_validate_strings.py
tests/validators/test_arguments.py
tests/validators/test_union.py
tests/validators/test_definitions_recursive.py
tests/validators/test_with_default.py
tests/validators/test_pickling.py
tests/validators/test_list.py
tests/validators/test_allow_partial.py
tests/validators/test_nullable.py
tests/validators/test_typed_dict.py
tests/validators/test_model_init.py
tests/validators/test_function.py
tests/validators/test_is_instance.py
tests/validators/test_tuple.py
tests/validators/test_model_fields.py
tests/validators/test_json.py
tests/validators/test_uuid.py
tests/validators/test_model.py
tests/validators/test_dataclasses.py
tests/validators/test_json_or_python.py
tests/benchmarks/test_serialization_micro.py
tests/benchmarks/test_micro_benchmarks.py
tests/benchmarks/nested_schema.py
tests/serializers/test_other.py
tests/serializers/test_any.py
tests/serializers/test_serialize_as_any.py
tests/serializers/test_model.py
tests/serializers/test_dataclasses.py
|
|
please review :) |
mikeedjones
changed the title
SchemaValidators in the test suite.
davidhewitt
reviewed
Feb 10, 2025
tests/validators/test_dataclasses.py
Outdated
There was a problem hiding this comment.
Changes in this file look like they have removed cases unintentionally, perhaps revert this file?
| @@ -1655,15 +1603,15 @@ def test_frozen_field(): | |||
| 'config,schema_extra_behavior_kw', | |||
| [ | |||
| (core_schema.CoreConfig(extra_fields_behavior='allow'), {}), | |||
| (core_schema.CoreConfig(extra_fields_behavior='allow'), {'extra_behavior': None}), | |||
| (core_schema.CoreConfig(extra_fields_behavior='allow'), {}), | |||
There was a problem hiding this comment.
Similar changes here and below?
There was a problem hiding this comment.
thanks! found a few more cases as well! thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Changes the initialization of most of the
SchemaValidators in the test suite to usecore_schema.xxx_schema()functions instead of dicts, as proposed in #831, and explicitly calls the associatedCoreConfigtyped dicts for the config.Related issue number
#831
Checklist
pydantic-core(except for expected changes)Selected Reviewer: @sydney-runkle