Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add flag to integration tests to mitigate schema changes #1480

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Companion to pydantic/pydantic#10588

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #1480 will not alter performance

Comparing dh/integration-test-hack (88955c9) with main (903a1a9)

Summary

✅ 155 untouched benchmarks

Comment on lines 217 to 218
# FIXME: don't merge this; this is just to prove the strategy works
ref: dh/integration-test-hack
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge upstream before reverting this bit and merging here.

@davidhewitt davidhewitt force-pushed the dh/integration-test-hack branch from 10c3641 to 88955c9 Compare October 10, 2024 10:08
@davidhewitt
Copy link
Contributor Author

I see upstream got merged, so I'll merge here too if CI is green. Thanks!

@davidhewitt davidhewitt merged commit dc4846e into main Oct 10, 2024
29 checks passed
@davidhewitt davidhewitt deleted the dh/integration-test-hack branch October 10, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant