Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wasm build and tests #148

Merged
merged 4 commits into from
Jul 5, 2022
Merged

fix wasm build and tests #148

merged 4 commits into from
Jul 5, 2022

Conversation

samuelcolvin
Copy link
Member

try using pytest-speed as a substitute for pytest-benchmark for wasm builds.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #148 (3594bbd) into main (158ab9a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          44       44           
  Lines        4422     4422           
  Branches       31       31           
=======================================
  Hits         4321     4321           
  Misses        101      101           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158ab9a...3594bbd. Read the comment docs.

@samuelcolvin samuelcolvin changed the title pytest-speed for wasm fix wasm build and tests Jul 5, 2022
@samuelcolvin samuelcolvin mentioned this pull request Jul 5, 2022
@hoodmane
Copy link
Contributor

hoodmane commented Jul 5, 2022

Note that pytest-benchmark works on Pyodide's main branch, though I don't know what the differences are between pytest-benchmark and pytest-speed.

OverflowError: timestamp out of range for platform time_t

There are also errors with datetime on PyO3:
https://github.com/PyO3/pyo3/pull/2436/files#diff-0475f1ee5a37fa84fc40bdb6aa3e0e463ebbd19d67fa60b5872244497480dbd3
I assumed that it was not a real bug and is due to some dumb configuration mistake but seeing it here makes it more likely to be real. Someone will have to investigate.

@samuelcolvin samuelcolvin marked this pull request as ready for review July 5, 2022 19:03
@samuelcolvin samuelcolvin merged commit 1ed0b6a into main Jul 5, 2022
@samuelcolvin samuelcolvin deleted the pytest-speed-for-wasm2 branch July 5, 2022 19:04
@samuelcolvin
Copy link
Member Author

Interesting, thanks.

I've been working on pytest-speed today to fix some frustrations with pytest-benchmark, it's backwards compatible with pytest-benchmark in this codebase. I thought the problem was with a dependency of pytest-benchmark which didn't distribute wheels? Either way, over time I'll replace pytest-benchmark complete in time.

@hoodmane
Copy link
Contributor

hoodmane commented Jul 5, 2022

The problem is that py-cpuinfo doesn't support wasm. It would be an easy fix but py-cpuinfo doesn't look maintained.

@samuelcolvin
Copy link
Member Author

The whole of pytest-benchmark looks pretty unloved I'm afraid.

Quite about from the hard to read output, the actual measurements seem to vary a lot, hence why I went down the rabbit whole of starting anotherpackage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants