-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wasm build and tests #148
Conversation
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 44 44
Lines 4422 4422
Branches 31 31
=======================================
Hits 4321 4321
Misses 101 101 Continue to review full report at Codecov.
|
Note that
There are also errors with datetime on PyO3: |
Interesting, thanks. I've been working on pytest-speed today to fix some frustrations with pytest-benchmark, it's backwards compatible with pytest-benchmark in this codebase. I thought the problem was with a dependency of pytest-benchmark which didn't distribute wheels? Either way, over time I'll replace pytest-benchmark complete in time. |
The problem is that py-cpuinfo doesn't support wasm. It would be an easy fix but py-cpuinfo doesn't look maintained. |
The whole of pytest-benchmark looks pretty unloved I'm afraid. Quite about from the hard to read output, the actual measurements seem to vary a lot, hence why I went down the rabbit whole of starting anotherpackage. |
try using pytest-speed as a substitute for pytest-benchmark for wasm builds.