Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload wasm wheels to github release #128

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Upload wasm wheels to github release #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,3 +353,16 @@ jobs:
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.pypi_token }}

- name: get wasm dist artifacts
uses: actions/download-artifact@v3
with:
name: wasm_wheels
path: wasm

- name: upload to github release
uses: softprops/action-gh-release@v1
with:
files: |
wasm/*.whl
prerelease: ${{ contains(github.ref, 'alpha') || contains(github.ref, 'beta') }}
Comment on lines +363 to +368
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to creates a new release, we want to add the file to the existing (just created) release.

Looks like this action should do what we want.

Copy link
Contributor Author

@messense messense Jun 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That action also create new release if there is no pre-existing one: https://github.com/svenstaro/upload-release-action/blob/fb1eb39e74209484069862c0ad703e495f307650/src/main.ts#L27-L39

I think they behave pretty much the same, but svenstaro/upload-release-action doesn't handle network errors quite well which leads to upload failure sometimes.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humm are you sure softprops/action-gh-release will add the files to an existing release if it's triggered from that release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so.

https://github.com/softprops/action-gh-release/blob/50195ba7f6f93d1ac97ba8332a178e008ad176aa/src/github.ts#L201-L289

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I guess we'll find out...