Improve string format handling for gemini #609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue demonstrated in #582.
In particular, this PR pops the
'format'
field from string schemas (the presence of which is causing API errors), and uses it to modify the field description, which seems to result in responses that don't have errors and parse successfully.This PR doesn't go as far as was requested in that issue, but the approach I've used here seems reasonable given we do get API errors without it, it seems like a common usage scenario, and I also confirmed manually with
gemini-1.5-flash
that the changes in this PR result in responses that parse successfully, at least for the specific prompt/model I was using (basically the one from that issue).Weirdly, the VertexAI docs say that:
But in practice it didn't seem to work with any of these. If/when those format values do start to work, we could revert this change.