Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize consume_ident #47

Closed
wants to merge 1 commit into from
Closed

optimize consume_ident #47

wants to merge 1 commit into from

Conversation

davidhewitt
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #47 (eccf455) into main (36b2354) will decrease coverage by 0.07%.
The diff coverage is 92.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   89.56%   89.50%   -0.07%     
==========================================
  Files           8        8              
  Lines        1045     1048       +3     
==========================================
+ Hits          936      938       +2     
- Misses        109      110       +1     
Files Coverage Δ
src/parse.rs 97.59% <92.30%> (-0.57%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b2354...eccf455. Read the comment docs.

Copy link

codspeed-hq bot commented Nov 30, 2023

CodSpeed Performance Report

Merging #47 will degrade performances by 29.71%

Comparing dh/consume_ident (eccf455) with main (36b2354)

Summary

❌ 3 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/consume_ident Change
true_array_jiter_value 53.8 µs 64.8 µs -16.9%
true_array_jiter_iter 28.4 µs 40.4 µs -29.71%
python_parse_true_array 58.2 µs 69.3 µs -16.13%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant