Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid measuring allocation in jiter iter benches #46

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

davidhewitt
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #46 (bc61a6f) into main (f6739a8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   89.56%   89.56%           
=======================================
  Files           8        8           
  Lines        1045     1045           
=======================================
  Hits          936      936           
  Misses        109      109           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6739a8...bc61a6f. Read the comment docs.

Copy link

codspeed-hq bot commented Nov 30, 2023

CodSpeed Performance Report

Merging #46 will improve performances by 57.41%

Comparing dh/bench-vec (bc61a6f) with main (f6739a8)

Summary

⚡ 4 improvements
✅ 33 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/bench-vec Change
massive_ints_array_jiter_iter 5.2 ms 4.4 ms +17.08%
string_array_jiter_iter 63.5 µs 48.2 µs +31.74%
true_array_jiter_iter 38.1 µs 28.4 µs +34.44%
true_object_jiter_iter 194.5 µs 123.6 µs +57.41%

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidhewitt davidhewitt merged commit 36b2354 into main Nov 30, 2023
@davidhewitt davidhewitt deleted the dh/bench-vec branch November 30, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants