Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: remove use of smallvec #38

Closed
wants to merge 1 commit into from
Closed

Conversation

samuelcolvin
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #38 (efd7a77) into main (9a7beb9) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files           8        8           
  Lines        1021     1021           
=======================================
  Hits          916      916           
  Misses        105      105           
Files Coverage Δ
src/lazy_index_map.rs 68.49% <100.00%> (ø)
src/python.rs 97.50% <100.00%> (ø)
src/value.rs 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7beb9...efd7a77. Read the comment docs.

Copy link

codspeed-hq bot commented Nov 23, 2023

CodSpeed Performance Report

Merging #38 will not alter performance

Comparing no-smallvec (efd7a77) with main (9a7beb9)

Summary

✅ 32 untouched benchmarks

@samuelcolvin
Copy link
Member Author

no improvement, slight increase from local benchmark comparison:

name                            main.bench ns/iter  no-smallvec.bench ns/iter  diff ns/iter  diff %  speedup 
 big_jiter_iter                  7,190,146           7,091,030                       -99,116  -1.38%   x 1.01 
 big_jiter_value                 10,794,444          14,240,699                    3,446,255  31.93%   x 0.76 
 big_serde_value                 40,160,181          38,147,954                   -2,012,227  -5.01%   x 1.05 
 bigints_array_jiter_iter        32,694              32,184                             -510  -1.56%   x 1.02 
 bigints_array_jiter_value       38,692              38,154                             -538  -1.39%   x 1.01 
 bigints_array_serde_value       132,247             119,202                         -13,045  -9.86%   x 1.11 
 floats_array_jiter_iter         35,858              36,009                              151   0.42%   x 1.00 
 floats_array_jiter_value        53,136              54,637                            1,501   2.82%   x 0.97 
 floats_array_serde_value        229,845             218,685                         -11,160  -4.86%   x 1.05 
 massive_ints_array_jiter_iter   163,127             155,478                          -7,649  -4.69%   x 1.05 
 massive_ints_array_jiter_value  173,245             168,608                          -4,637  -2.68%   x 1.03 
 massive_ints_array_serde_value  525,977             500,043                         -25,934  -4.93%   x 1.05 
 medium_response_jiter_iter      0                   0                                     0    NaN%    x NaN 
 medium_response_jiter_value     9,801               9,715                               -86  -0.88%   x 1.01 
 medium_response_serde_value     14,264              12,960                           -1,304  -9.14%   x 1.10 
 pass1_jiter_iter                0                   0                                     0    NaN%    x NaN 
 pass1_jiter_value               6,249               6,358                               109   1.74%   x 0.98 
 pass1_serde_value               9,195               9,233                                38   0.41%   x 1.00 
 pass2_jiter_iter                416                 418                                   2   0.48%   x 1.00 
 pass2_jiter_value               1,222               1,348                               126  10.31%   x 0.91 
 pass2_serde_value               1,210               1,141                               -69  -5.70%   x 1.06 
 string_array_jiter_iter         1,676               1,679                                 3   0.18%   x 1.00 
 string_array_jiter_value        7,124               7,204                                80   1.12%   x 0.99 
 string_array_serde_value        6,705               6,545                              -160  -2.39%   x 1.02 
 true_array_jiter_iter           853                 1,045                               192  22.51%   x 0.82 
 true_array_jiter_value          1,798               1,870                                72   4.00%   x 0.96 
 true_array_serde_value          2,342               2,306                               -36  -1.54%   x 1.02 
 true_object_jiter_iter          5,859               5,703                              -156  -2.66%   x 1.03 
 true_object_jiter_value         8,705               8,405                              -300  -3.45%   x 1.04 
 true_object_serde_value         10,816              11,269                              453   4.19%   x 0.96 

@samuelcolvin samuelcolvin deleted the no-smallvec branch November 23, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant