Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #976

Closed
wants to merge 1 commit into from
Closed

Update __init__.py #976

wants to merge 1 commit into from

Conversation

MikhailToropov
Copy link

Fix problem with add_attachment(issue, file). RuntimeError: dictionary keys changed during iteration for Python 3.8

Fix problem with add_attachment(issue, file). RuntimeError: dictionary keys changed during iteration for Python 3.8
@adehad adehad added bug Status: Needs Rework PR has been submitted, but changes required. labels May 2, 2021
@studioj studioj closed this May 24, 2021
@studioj
Copy link
Collaborator

studioj commented May 24, 2021

@MikhailToropov please add a test to check for the fixing of the bug, merge latest CI changes from master in your branch and make sure CI passes before we start a review on this. Thank you

@studioj studioj reopened this May 24, 2021
@adehad
Copy link
Contributor

adehad commented Jun 22, 2021

I'm tempted to say we should be using the CaseInsensitiveDict from requests.structures directly, rather than this implementation. We can then be confident it is well tested too?

@adehad
Copy link
Contributor

adehad commented Jun 26, 2021

Refer #1084

@adehad adehad closed this Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Status: Needs Rework PR has been submitted, but changes required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants