Fixed search users to use query instead of user. #941
Closed
+4
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in JIRA API due to GDPR deprecations.
|
Please merge this, the user search functionality is not usable otherwise. |
adehad
reviewed
May 2, 2021
| ): | ||
| """Get a list of user Resources that match the specified search string. | ||
|
|
||
| :param user: a string to match usernames, name or email against. | ||
| :type user: str | ||
| :param query: a string to match usernames, name or email against. |
There was a problem hiding this comment.
Fundamentally the function is still asking for a 'user', it is just the API that puts this under the 'query' request parameter. Therefore, I think keeping the argument as 'user' is fine
|
@ursulahuang please black your branch and pull in changes from master |
studioj
added
the
Status: Needs Rework
|
closing as covered by #927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
userparameter was removed in JIRA API due to GDPR deprecations.search_usersseems to use theuser/searchendpoint. In this endpoint, theuserparameter has been replaced with thequeryparameter.