Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Custom Certificates #1203

Closed
wants to merge 4 commits into from

Conversation

kchason
Copy link
Contributor

@kchason kchason commented Oct 29, 2021

With the bump of the Requests library in 3.1.0rc1, self-signed certificates or those issued by custom certificate authorities triggers an error like:

10/29/2021 03:54:03 PM:WARNING:Got ConnectionError [HTTPSConnectionPool(host='redacted', port=443): Max retries exceeded with url: /rest/api/2/serverInfo (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1129)')))] errno:None on GET https://redacted/rest/api/2/serverInfo

This branch adds a new option for providing the certificate authority that signed the server SSL certificate.

Closes #1159

@kchason
Copy link
Contributor Author

kchason commented Oct 29, 2021

I can't add a label which is failing the associated GitHub Action job but it should be bug

@adehad
Copy link
Contributor

adehad commented Oct 30, 2021

@kchason I prefer not adding additional arguments, especially as we are currently handling the argument incorrectly anyway. So I am partial to #1202, I believe it should also work for your case.

@adehad adehad closed this Oct 30, 2021
@studioj
Copy link
Collaborator

studioj commented Oct 30, 2021

thanks for bringin this to light though @kchason ...
please review #1202 lets see if that would also work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to tolerate SSLError complaining about self-signed certificate
3 participants