Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the adding of headers rather than just overwriting all headers #1085

Merged
merged 4 commits into from
Aug 28, 2021
Merged

Allow the adding of headers rather than just overwriting all headers #1085

merged 4 commits into from
Aug 28, 2021

Conversation

adehad
Copy link
Contributor

@adehad adehad commented Jun 26, 2021 •
edited
Loading

Replaces #958

@adehad adehad mentioned this pull request Jun 26, 2021
Closed
@adehad adehad force-pushed the feat/non_clobbering_headers_update branch from 000cfd3 to 8ab9b6f Compare June 26, 2021 16:05
@adehad adehad requested review from ssbarnea and studioj June 26, 2021 16:50
@adehad adehad force-pushed the feat/non_clobbering_headers_update branch from 8ab9b6f to 3195c83 Compare July 10, 2021 15:40
@adehad
Copy link
Contributor Author

adehad commented Jul 10, 2021

@studioj how does this look?

studioj
studioj reviewed Jul 21, 2021
View reviewed changes
Copy link
Collaborator

@studioj studioj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the rest it seems ok...
although the reason why to add this is kinda unclear from the code you;re adding
maybe add an example in hte examples?

@adehad adehad requested a review from studioj July 23, 2021 18:31
@studioj studioj added the Status: Ready for Merge PR looks good to merge label Aug 28, 2021
@studioj
Copy link
Collaborator

studioj commented Aug 28, 2021

@ssbarnea ready for merge :-)

@adehad adehad merged commit fe78ddd into master Aug 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/non_clobbering_headers_update branch August 28, 2021 11:07
svermeulen pushed a commit to svermeulen/jira that referenced this pull request Oct 31, 2021
@adehad @pradcliffe-ns @svermeulen
Allow the adding of headers rather than just overwriting all headers (…
c295c4b 
…pycontribs#1085)

* Allow the adding of headers rather than just overwriting all headers

Co-Authored-By: Peter Radcliffe <[email protected]>

* add tests for unclobbered headers update

asda

* update tests to be less dependent on input test case

* add to examples how this may be used

Co-authored-by: Peter Radcliffe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@studioj studioj studioj approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea

Assignees
No one assigned
Labels
enhancement Status: Ready for Merge PR looks good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify different UA
2 participants
@adehad @studioj