-
-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle 429 rate limiting messages from Jira #925
Labels
Comments
hi, any news with that? |
stefanoboriero
pushed a commit
to stefanoboriero/jira
that referenced
this issue
Apr 19, 2022
* enable retries of 5xx status codes * add status code 429 to the list of retriable errors * remove status code 401 from the list of retriable errors by resilientsession FIXES pycontribs#925
stefanoboriero
pushed a commit
to stefanoboriero/jira
that referenced
this issue
Apr 19, 2022
* enable retries of 5xx status codes * add status code 429 to the list of retriable errors * remove status code 401 from the list of retriable errors by resilientsession FIXES pycontribs#925
stefanoboriero
pushed a commit
to stefanoboriero/jira
that referenced
this issue
Apr 19, 2022
* enable retries of 5xx status codes * add status code 429 to the list of retriable errors * remove status code 401 from the list of retriable errors by resilientsession FIXES pycontribs#925
Hello, I'd be interested in this as well so I tried to contribute with a PR: happy for it be reviewed! |
stefanoboriero
pushed a commit
to stefanoboriero/jira
that referenced
this issue
Apr 24, 2022
* add status code 429 to the list of retriable errors FIXES pycontribs#925
stefanoboriero
pushed a commit
to stefanoboriero/jira
that referenced
this issue
Apr 24, 2022
* add status code 429 to the list of retriable errors FIXES pycontribs#925
stefanoboriero
pushed a commit
to stefanoboriero/jira
that referenced
this issue
Apr 26, 2022
* add status code 429 to the list of retriable errors FIXES pycontribs#925
stefanoboriero
pushed a commit
to stefanoboriero/jira
that referenced
this issue
Apr 26, 2022
* add status code 429 to the list of retriable errors FIXES pycontribs#925
stefanoboriero
pushed a commit
to stefanoboriero/jira
that referenced
this issue
Apr 27, 2022
* add status code 429 to the list of retriable errors FIXES pycontribs#925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Atlassian recommends usage of rate limiting with Jira in this blog post: https://confluence.atlassian.com/adminjiraserver/improving-instance-stability-with-rate-limiting-983794911.html
This would result in getting a 429 status code. From what I can tell this library will never retry these requests.
Describe the solution you'd like
Use the existing exponential backoff logic to (eventually) retry a request that was ratelimited.
Describe alternatives you've considered
I have not really considered any alternative here.
Additional context
Admittedly this may be handled elsewhere and I may have missed it, I have not rolled out the ratelimiting yet so I do not have real world testing here.
The text was updated successfully, but these errors were encountered: