-
-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource RequestType is broken in 3.x #1130
Comments
@bmathieu33 Thanks for your report. Could you edit your issue with a simple way to reproduce... that would be awesome. Thx for investigating the commits and dont hesitate to create a fork and open a PR to possibly fix this (who knows with a test to validate its fix ;-)) |
@studioj I have added a simple way to reproduce, and a small PR to fix this. Sorry I cannot take the time investigate more how to add a test. I searched and found no tests case was already set up for this resource (only an empty file). |
…s#1130) (pycontribs#1133) * fix TB on RequestType instanciation with raw content (fixes pycontribs#1130)
The class cannot be instanciated with raw content, since v3.
The commit b07a074abf6773c has changed
RequestType.__init__
method, trying to parse raw content before having calledResource.__init__()
. This leads to this kind of traceback, using release 3.0.1:Other resource classes have not been changed, so it seems this changed has been introduced by accident.
To reproduce:
Traceback:
The text was updated successfully, but these errors were encountered: