Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errors with latest flake8 #710

Merged
merged 4 commits into from
Nov 20, 2017
Merged

fix errors with latest flake8 #710

merged 4 commits into from
Nov 20, 2017

Conversation

alex
Copy link
Member

@alex alex commented Nov 20, 2017

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #710 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #710   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files          16       16           
  Lines        5631     5631           
  Branches      391      391           
=======================================
  Hits         5463     5463           
  Misses        112      112           
  Partials       56       56
Impacted Files Coverage Δ
src/OpenSSL/SSL.py 94.88% <100%> (ø) ⬆️
tests/test_crypto.py 98.92% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe0120f...673a7e3. Read the comment docs.

@alex
Copy link
Member Author

alex commented Nov 20, 2017

urllib3's tests appear broken, unrelated to us. Should I move them into allow_failures for now?

@reaperhulk reaperhulk merged commit c3697ad into pyca:master Nov 20, 2017
@alex alex deleted the flake8-fixes branch November 20, 2017 13:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants